Skip to content

fix: (storage) fix the oom issue to delete bucket - #17772

Merged
rileykarson merged 4 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:oom_bucket_issue
Jun 10, 2026
Merged

fix: (storage) fix the oom issue to delete bucket#17772
rileykarson merged 4 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:oom_bucket_issue

Conversation

@gurusai-voleti

@gurusai-voleti gurusai-voleti commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.
Fixes: hashicorp/terraform-provider-google#27530

storage: fixed OOM issue for `google_storage_bucket` `force_destroy` by limiting the number of outstanding tasks to 2000

@github-actions
github-actions Bot requested a review from rileykarson June 1, 2026 07:36
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3767277:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 116 insertions(+), 113 deletions(-)
google-beta provider View Diff 1 file changed, 116 insertions(+), 113 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • storage

Please fix the compilation errors to complete your PR.

View the build log

@gurusai-voleti, @rileykarson, @googlyrahman VCR tests complete for 3767277!

@modular-magician

modular-magician commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c205e1c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 20 insertions(+), 4 deletions(-)
google-beta provider View Diff 1 file changed, 20 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
135 124 11 0
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@gurusai-voleti, @rileykarson, @googlyrahman VCR tests complete for c205e1c!

@modular-magician

modular-magician commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d546524:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 9 insertions(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 9 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
135 124 11 0
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@gurusai-voleti, @rileykarson, @googlyrahman VCR tests complete for d546524!

@modular-magician

modular-magician commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7d7bbc0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 9 insertions(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 9 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
136 125 11 0
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@gurusai-voleti, @googlyrahman VCR tests complete for 7d7bbc0!

@rileykarson rileykarson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for service reviewer approval to merge.

@github-actions

Copy link
Copy Markdown

@rileykarson This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@rileykarson
rileykarson added this pull request to the merge queue Jun 10, 2026
Merged via the queue into GoogleCloudPlatform:main with commit eaa22e2 Jun 10, 2026
25 checks passed
muresan pushed a commit to muresan/magic-modules that referenced this pull request Jun 15, 2026
axelkossek pushed a commit to axelkossek/magic-modules that referenced this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emptying of storage buckets with many objects/versions OOM in 7.15+

4 participants