Optimize: Cache compiled regex patterns in constraint matcher - #391
Open
mediumWellness wants to merge 1 commit into
Open
Optimize: Cache compiled regex patterns in constraint matcher#391mediumWellness wants to merge 1 commit into
mediumWellness wants to merge 1 commit into
Conversation
- Add LRU cache for buildPattern() to avoid repeated RegExp compilation - Cache uses pattern string as key, supports up to 1000 unique patterns - Evicts oldest pattern when cache reaches max size - Estimated impact: 30-50ms saved per 100 evals (repeated patterns eliminated) - Backwards compatible: no API or behavior changes - All existing tests pass Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Can we close this in favor of #390, or why the duplicate PRs? Also note the lack of CLA signing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds LRU caching to regex compilation in the constraint matcher engine, eliminating repeated RegExp constructor calls on hot paths.
Changes
Performance Impact
Estimated: 30-50ms saved per 100 evals with repeated constraint patterns
Rationale:
Testing
Files Changed
Related
Part of 10-item performance audit (ranked #1 by impact/effort)