Skip to content

Bump SharpCompress from 0.48.1 to 0.50.1 - #79

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.1
Closed

Bump SharpCompress from 0.48.1 to 0.50.1#79
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor

Updated SharpCompress from 0.48.1 to 0.50.1.

Release notes

Sourced from SharpCompress's releases.

0.50.1

What's Changed

Thanks for reporting!

Full Changelog: adamhathcock/sharpcompress@0.50.0...0.50.1

0.50.0

Breaking changes:

  • Tar Archive does not try to decompress streams anymore. TarReader will still do this.
  • Detection API changed.
  • CRC should be more complete and enabled by default

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.49.1...0.50.0

0.49.1

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0...0.49.1

0.49.0

This should contain a lot of write async fixes and some breaking API changes that fix previous broke net48 usage

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0

0.49.0-beta.140

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0-beta.136...0.49.0-beta.140

0.49.0-beta.136

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0-beta1

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump SharpCompress from 0.48.1 to 0.50.1
96fc60f 
---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-version: 0.50.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Jul 27, 2026
@dependabot
dependabot Bot requested a review from GoodOlClint as a code owner July 27, 2026 12:36
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Jul 27, 2026
@dependabot dependabot Bot mentioned this pull request Jul 27, 2026
Closed
@claude

claude Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Claude finished @dependabot[bot]'s task in 1m 27s —— View job

Review: Bump SharpCompress 0.48.1 → 0.50.1

  • Gather context (PR diff, changed files)
  • Check DECISIONS.md for relevant constraints
  • Check docs/review/findings.json for open findings touching SharpCompress
  • Determine how/where SharpCompress is used in the codebase
  • Assess breaking changes between 0.48.1 → 0.50.1 for impact on usage
  • Attempt build/test (blocked — see note below)
  • Post final review

Summary

Single-line dependency bump in src/PSProxmoxVE.Core/PSProxmoxVE.Core.csproj (SharpCompress 0.48.1 → 0.50.1). No source changes.

DECISIONS.md / findings.json: No mentions of SharpCompress in either file — no established decisions or open findings apply here.

Usage surface: The only consumer in this repo is OvfMetadata.ExtractOvfFromTar in src/PSProxmoxVE.Core/Models/Vms/OvfMetadata.cs:86-104, which uses the low-level streaming SharpCompress.Readers.ReaderFactory.OpenReader / OpenEntryStream API to pull a .ovf file out of an OVA tarball.

Breaking-change review (0.49.0 / 0.50.0 release notes):

  • "Tar Archive does not try to decompress streams anymore; TarReader still does" — this repo uses ReaderFactory/TarReader (streaming API), not TarArchive, so this breaking change doesn't apply.
  • "LeaveStreamOpen default changed from true to false" — irrelevant here since both the entry stream and the underlying file stream are wrapped in using and disposed together; nothing depends on the stream staying open afterward.
  • "Detection API changed" — not used; this code calls ReaderFactory.OpenReader directly rather than the detection helpers.
  • 0.50.1 specifically fixes ReaderFactory/GZip-in-tar detection bugs (ArgumentException on mid-stream GZip probe disposal, tar.gz entry-stream detection) — directly relevant to this exact code path and a net positive for correctness.
  • netstandard2.0 (this project's target) remains supported; 0.49.0 notes explicitly call out adjustments to avoid breaking legacy framework targets.

Tests: An integration test exercising this path exists at tests/PSProxmoxVE.Tests/Integration/12_OVA.Tests.ps1. No xUnit unit test directly covers OvfMetadata.FromOva/ExtractOvfFromTar in tests/PSProxmoxVE.Core.Tests/ (pre-existing gap, not introduced by this PR).

Note: I was unable to run dotnet build/dotnet test in this session (Bash tool calls required approval that wasn't available). Please confirm CI (build + xUnit + Pester) passes green before merging — based on static review there's no reason to expect a break.

Verdict: Low risk. No DECISIONS.md violations, no security concerns (build-time dependency only, no credential handling), no API surface used by this repo is affected by the breaking changes between these versions. Safe to merge once CI is green.

@dependabot @github

dependabot Bot commented on behalf of github Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #80.

@dependabot dependabot Bot closed this Aug 3, 2026
@dependabot
dependabot Bot deleted the dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.50.1 branch August 3, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GoodOlClint GoodOlClint Awaiting requested review from GoodOlClint

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants