chore(ci): bump actions/checkout to v5 for the Node 24 runtime (closes #19) - #25
Closed
dchaudhari7177 wants to merge 1 commit into
Closed
chore(ci): bump actions/checkout to v5 for the Node 24 runtime (closes #19)#25dchaudhari7177 wants to merge 1 commit into
dchaudhari7177 wants to merge 1 commit into
Conversation
Every CI run was annotated with "Node.js 20 is deprecated ... actions/checkout@v4". v5.0.0 is the release that switched the action to node24 (actions/checkout#2226); v4.x still declares `using: node20`. I checked both action.yml files rather than going by the changelog alone. actions/checkout is the only offender here. oven-sh/setup-bun@v2 already declares `using: "node24"`, which matches the annotation naming checkout alone, so this one line clears it. Stopped at v5 rather than the current v7 deliberately: v5 is exactly the version that drops Node 20, while v6 changes how credentials are persisted and v7 moves to ESM and blocks fork-PR checkouts for pull_request_target / workflow_run. None of that is needed to fix this, and this workflow triggers on pull_request rather than pull_request_target so it would be a no-op risk. Happy to go to v7 instead if you would rather track the latest major. v5 requires runner v2.327.1 or newer, which ubuntu-latest is well past. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19.
Which version actually drops Node 20
Rather than going by the changelog, I read
action.ymlat each tag:v5.0.0 is the release that switched (actions/checkout#2226). So
@v5is the fix.checkout is the only offender
I also checked the other action in the workflow:
It's already on Node 24 — which matches the annotation naming only
actions/checkout@v4. So this one line clears the warning entirely; there's no second bump waiting behind it.Why v5 and not v7
v7.0.1 is the current release, and I deliberately didn't go there:
pull_request_target/workflow_run.Neither is needed to fix a Node 20 deprecation, and both are behaviour changes this issue didn't ask for. For what it's worth, v7's fork-PR restriction wouldn't bite here — this workflow triggers on
pull_request, notpull_request_target— so if you'd rather track the latest major, say the word and I'll change it to@v7. I went minimal because that's what the issue scoped.v5 requires runner v2.327.1 or newer;
ubuntu-latestis well past that.Verification
Nothing here is locally runnable, as the issue notes — the real check is the next CI run. What I could confirm:
v5exists as a moving major tag on actions/checkout, and itsaction.ymldeclaresnode24The annotation should be gone from the CI run on this PR.
🤖 Generated with Claude Code