fix: recompute scheduled tokens after prefix-cache allocation#210
Open
tj1235 wants to merge 1 commit into
Open
fix: recompute scheduled tokens after prefix-cache allocation#210tj1235 wants to merge 1 commit into
tj1235 wants to merge 1 commit into
Conversation
Owner
|
Thank your advice. We fixed it in newest PR #218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a scheduling bug when prefix cache hits.
Previously, schedule() computed
num_tokensbeforeblock_manager.allocate(seq).However,
allocate(seq)may increaseseq.num_cached_tokenswhen a prefix blockis reused from cache. This made
seq.num_scheduled_tokensstale and could causeprepare_prefill()to build an invalid[start, end)range, eventually leadingto
block_tableindex overflow.Fix:
num_tokensafterallocate(seq)seq.num_scheduled_tokensfrom the updated cached-token countReproduction:
seq.num_cached_tokens = 256seq.num_scheduled_tokenscould still remain465prepare_prefill()would computestart = 256, end = 721, which exceedsthe true sequence length and causes out-of-range access on
seq.block_tableValidation:
seq.num_scheduled_tokensbecomes465 - 256 = 209