Skip to content

Fix the initialisation of Rnd in FlatZinc#2

Merged
chschulte merged 2 commits into
Gecode:developfrom
Dekker1:fix/flatzinc_random
Mar 8, 2018
Merged

Fix the initialisation of Rnd in FlatZinc#2
chschulte merged 2 commits into
Gecode:developfrom
Dekker1:fix/flatzinc_random

Conversation

@Dekker1

@Dekker1 Dekker1 commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

This commit fixes the passing of the rnd value from main and initialises the default random number generator.

This PR is made after some issues of an un-initialised random number generator while developing an fzn-gecode extension

This commit fixes the passing of the rnd value from main and initialises the default random number generator.
@chschulte

Copy link
Copy Markdown
Member

The fix itself looks good, however we would also need an entry into the file changelog.in.

Cheers Christian

@Dekker1

Dekker1 commented Mar 6, 2018

Copy link
Copy Markdown
Contributor Author

@chschulte, sorry for the oversight. I've added a change log entry.

I did come across an issue with the changelog.in file. Even though it seems to be UTF-8 encoded, all my editors (CLion, VSCode, and Atom) seem to have problems reading some non-ASCII characters. I had to use git add --patch to not change the rest of the file.

@chschulte chschulte merged commit ae2ea06 into Gecode:develop Mar 8, 2018
@chschulte

Copy link
Copy Markdown
Member

Yep, it is in fact ISO-LATIN. Don't want to touch it, as I do not knows what will happen with the Windows build toolchain.

@guidotack

guidotack commented Mar 8, 2018 via email

Copy link
Copy Markdown
Member

@Dekker1 Dekker1 deleted the fix/flatzinc_random branch June 15, 2018 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants