refactor(core): move stable AI DTOs into core types#1119
Merged
Conversation
e2a3310 to
bc83415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-core-types.bitfun-ai-adapters::typesandbitfun-core::util::typescompatibility exports.Risk and impact
GeminiUsageandGeminiResponseremain adapter-owned because they depend on stream usage conversion details.bitfun-core --no-default-featureskeeps remote SSH workspace identity as a compatibility dependency; this PR only trims the concrete AI/runtime/debug/search owners documented in the plan.Verification
pnpm run fmt:rsnode --test scripts\check-core-boundaries.test.mjsnode scripts\check-core-boundaries.mjscargo test -p bitfun-core-typescargo test -p bitfun-ai-adapterscargo check -p bitfun-core --no-default-featurescargo check -p bitfun-core --no-default-features --features product-fullcargo check -p bitfun-core --no-default-features --features product-domainscargo check -p bitfun-clicargo check -p bitfun-acpcargo check -p bitfun-desktoppnpm run check:repo-hygienecargo metadata --no-deps --format-version 1git diff --checkcargo tree -p bitfun-core --no-default-features --depth 1 | Select-String -Pattern 'bitfun-ai-adapters|reqwest|axum|tower-http|workspace-search|remote-ssh-concrete'