Skip to content

refactor(core): move stable AI DTOs into core types#1119

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-m12-runtime-owners
Jun 9, 2026
Merged

refactor(core): move stable AI DTOs into core types#1119
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-m12-runtime-owners

Conversation

@limityan

@limityan limityan commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move stable AI config, message, tool-call, and connection-test DTOs into bitfun-core-types.
  • Preserve legacy bitfun-ai-adapters::types and bitfun-core::util::types compatibility exports.
  • Gate concrete AI adapter runtime, CLI credential acquisition, debug ingest, workspace search, and direct HTTP server/client dependencies behind explicit core features.
  • Extend core-boundary rules and self-tests so no-default core stays free of concrete AI/HTTP/workspace-search owners, contracts do not encode provider endpoint behavior, and product-domain facade feature dependencies stay complete.

Risk and impact

  • No provider request/stream behavior is intentionally changed; adapter tests cover request URL compatibility and stream behavior.
  • GeminiUsage and GeminiResponse remain adapter-owned because they depend on stream usage conversion details.
  • bitfun-core --no-default-features keeps remote SSH workspace identity as a compatibility dependency; this PR only trims the concrete AI/runtime/debug/search owners documented in the plan.

Verification

  • pnpm run fmt:rs
  • node --test scripts\check-core-boundaries.test.mjs
  • node scripts\check-core-boundaries.mjs
  • cargo test -p bitfun-core-types
  • cargo test -p bitfun-ai-adapters
  • cargo check -p bitfun-core --no-default-features
  • cargo check -p bitfun-core --no-default-features --features product-full
  • cargo check -p bitfun-core --no-default-features --features product-domains
  • cargo check -p bitfun-cli
  • cargo check -p bitfun-acp
  • cargo check -p bitfun-desktop
  • pnpm run check:repo-hygiene
  • cargo metadata --no-deps --format-version 1
  • git diff --check
  • cargo tree -p bitfun-core --no-default-features --depth 1 | Select-String -Pattern 'bitfun-ai-adapters|reqwest|axum|tower-http|workspace-search|remote-ssh-concrete'

@limityan limityan force-pushed the yanzhn/refactor-m12-runtime-owners branch from e2a3310 to bc83415 Compare June 9, 2026 10:10
@limityan limityan merged commit 568dbfd into GCWing:main Jun 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant