Fix ACP session recovery#1052
Merged
Merged
Conversation
f85082c to
e073822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
acp:<client>agent type so the input capsule close action cannot silently switch them back to the normal agentic path.cancel_acp_dialog_turnwith workspace and remote identifiers.restoring sessionstuck on screen.Why
Closing the ACP capsule prevented the same chat from returning to ACP mode, and switching back to a long-running ACP session could leave the UI stuck on
restoring session. The root cause was frontend state losing the ACP agent type and pending restore UI state lacking a robust cleanup path.Validation
pnpm --dir src/web-ui run test:run src/flow_chat/utils/acpSession.test.ts src/flow_chat/utils/chatInputMode.test.tspnpm run type-check:webgit diff --check