Skip to content

Style Refactoring#243

Merged
csharpfritz merged 8 commits intoFritzAndFriends:devfrom
hishamco:style-refactoring
Sep 8, 2020
Merged

Style Refactoring#243
csharpfritz merged 8 commits intoFritzAndFriends:devfrom
hishamco:style-refactoring

Conversation

@hishamco
Copy link
Copy Markdown
Collaborator

@hishamco hishamco commented Aug 30, 2020

This include:

  • Introduce FontInfo to hold all the font related properties

  • Organize style related related types

  • Rename IHasXXXStyle to IXXXStyle

  • Implement IStyle in Component to avoid implement the interface over and over again

@hishamco
Copy link
Copy Markdown
Collaborator Author

This is ended up with a Component something similar to WebControl in the ASP.NET WebForms, also we already have DataBoundComponent which make everything is clear and clean, no more IHasStyle anymore because it's built-in in the Component

This PR shows the basic control got cleaner after remove all the IHasStyle properties and CalculatedStyle, I will continue after this to let all the components inherits from Component or DataBoundComponent

@hishamco hishamco changed the title Style refactoring Style Refactoring Aug 30, 2020
@hishamco hishamco closed this Aug 30, 2020
@hishamco hishamco reopened this Aug 30, 2020
@hishamco hishamco closed this Aug 30, 2020
@hishamco hishamco reopened this Aug 30, 2020
@hishamco
Copy link
Copy Markdown
Collaborator Author

hishamco commented Aug 30, 2020

Trying to close and open PR to let CI/CD run the test again, but no luck

@hishamco
Copy link
Copy Markdown
Collaborator Author

I squash the commit and force push, then the tests pass, @csharpfritz please merge #244 because it might break the build on any PR

Comment thread src/BlazorWebFormsComponents/Component.cs Outdated
@csharpfritz
Copy link
Copy Markdown
Collaborator

I'm not a fan of the renaming of all of the IxxxStyle interfaces without an issue to discuss first.

The changes are valuable, and would like to see the Component class renamed to something a little more descriptive first

@csharpfritz csharpfritz merged commit 03b8892 into FritzAndFriends:dev Sep 8, 2020
@csharpfritz
Copy link
Copy Markdown
Collaborator

This dramatically simplifies the implementation of these common style properties in our controls. Much appreciated!

@hishamco
Copy link
Copy Markdown
Collaborator Author

hishamco commented Sep 8, 2020

This dramatically simplifies the implementation of these common style properties in our controls.

Yes, it's

@hishamco hishamco deleted the style-refactoring branch September 8, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants