Fix SH2A_FPU FPU context cleanup#1444
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
portCLEAN_UP_TCBfor the RenesasSH2A_FPUport so task deletion releases the FPU context buffer stored throughpxTaskTag.xPortUsesFloatingPoint()idempotent when the task already has an FPU buffer, avoiding an immediate leak on repeated calls.portmacro.hsoport.cand the cleanup macro use the same constants.Root cause
xPortUsesFloatingPoint()allocates the FPU context buffer and stores a pointer just past the allocation inpxTaskTag, because the save routine uses a pre-decrement. The port did not defineportCLEAN_UP_TCB, soprvDeleteTCB()used the default no-op cleanup and the allocation became unreachable when the task was deleted.Fixes #1443
Validation
git diff --checkrgconfirmed the FPU buffer constants andportCLEAN_UP_TCBoverride are scoped toportable/Renesas/SH2A_FPU, withprvDeleteTCB()callingportCLEAN_UP_TCB( pxTCB )before freeing the TCB/stack.shc,ccsh,sh-elf-gcc,sh-none-elf-gcc,rx-elf-gcc, orccrxcommand was found on this machine.