fix: disable address normalization when checking blocked MMS senders - #644
Merged
Conversation
naveensingh
changed the title
naveensingh
changed the title
This is more accurate, but it shouldn't alter the blocking behavior, as the system handles that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Removed MMS sender address normalization when checking against blocked numbers. Previously, blocking an alphanumeric address such as
VE-ViCAREwould block MMS messages fromVE-ViCAREand the normalized number83842273. Even if that collision never occurs in the real world, removing normalization is the correct move and is consistent with how SMS blocking works.Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).