Require explicit access level and team scope on the MCP consent screen - #8419
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8419 +/- ##
=======================================
Coverage 76.76% 76.76%
=======================================
Files 459 459
Lines 24689 24689
Branches 6567 6567
=======================================
Hits 18953 18953
Misses 5736 5736
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cstns
force-pushed
the
8417-mcp-consent-no-preselect
branch
from
September 4, 2026 08:08
a57aee5 to
b6dcfaa
Compare
cstns
disabled the stack merge
September 4, 2026 10:35
n-lark
approved these changes
Sep 4, 2026
…t screen The consent page preselected "Full access" and "All teams", so the path of least resistance was to blindly click Allow. Both radio groups now start unselected and Allow stays disabled until the user has made both choices. Closes #8417
cstns
force-pushed
the
8417-mcp-consent-no-preselect
branch
from
September 7, 2026 07:20
b6dcfaa to
639f2eb
Compare
cstns
disabled the stack merge
September 7, 2026 08:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8417
The MCP OAuth consent page preselected "Full access" and "All teams", so the quickest path through was to blindly click Allow and hand the agent read/write access to everything.
Now both radio groups start with nothing selected, and the Allow button stays disabled until the user has picked an access level and a team scope (the existing "specific teams needs at least one team" guard still applies on top).
Added unit tests for the page covering the no-preselection state and the button gating.