Fix for CORE-5469: Handles allocated with isc_dsql_alloc_statement2() are not cleaned on disconnect#78
Merged
Conversation
hvlad
reviewed
Jan 30, 2017
hvlad
left a comment
hvlad
left a comment
Member
There was a problem hiding this comment.
Why massive move of code ? It is impossible to see what was changed in moved lines.
Contributor
Author
|
IscStatement cannot be in anonymous namespace anymore since it is used in declaration of YAttachment. Thus it has been moved into Why namespace. |
Member
|
It could be done in different commits to separate the logic from refactoring |
Contributor
Author
|
It could, yes. |
Member
|
Observations for all PRs: please put the ticket description, not only the number. |
aafemt
changed the title
Member
|
Dmitry please prepare same PR for 3.0 - it should be backported before closing ticket |
Contributor
Author
|
Dmitry please prepare same PR for 3.0
Can't be this commit just cherry-picked there? why.cpp wasn't changed much in ver.4, so in
theory it could be possible.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.