Skip to content

Use restricted list of C++11 features#48

Merged
asfernandes merged 12 commits into
masterfrom
work/c++11
Sep 22, 2016
Merged

Use restricted list of C++11 features#48
asfernandes merged 12 commits into
masterfrom
work/c++11

Conversation

@asfernandes

Copy link
Copy Markdown
Member

No description provided.

@asfernandes

Copy link
Copy Markdown
Member Author

@dyemanov what about merge this pull request?

@AlexPeshkoff

Copy link
Copy Markdown
Member

On 21.09.2016 18:46, Adriano dos Santos Fernandes wrote:

@dyemanov what about merge this pull request?

With what compilers did you try it ?

@hvlad

hvlad commented Sep 21, 2016

Copy link
Copy Markdown
Member

IIRC, snapshot build for Windows still produced using VC10 (VS2010). I doubt it supports all features in this branch.

@dyemanov

Copy link
Copy Markdown
Member

@hvlad, snapshots are built using MSVC13.

@asfernandes

Copy link
Copy Markdown
Member Author

@AlexPeshkoff clang++ 3.8.0, g++ 5.4.0 and MSVC 14.

@dyemanov

Copy link
Copy Markdown
Member

Compiles fine with MSVC2013, does not compile with MSVC10. More or less as expected.

@aafemt

aafemt commented Sep 21, 2016 via email

Copy link
Copy Markdown
Contributor

@asfernandes

Copy link
Copy Markdown
Member Author

No distro includes FB 4.

@aafemt

aafemt commented Sep 21, 2016 via email

Copy link
Copy Markdown
Contributor

@hvlad

hvlad commented Sep 21, 2016

Copy link
Copy Markdown
Member

snapshots are built using MSVC13.

Very good :) No objection from my side

@AlexPeshkoff

AlexPeshkoff commented Sep 21, 2016

Copy link
Copy Markdown
Member

Should better work with at least gcc 4.9. It's compiler used in current stable gentoo.
$ gcc --version
gcc (Gentoo 4.9.3 p1.4, pie-0.6.4) 4.9.3

@asfernandes

Copy link
Copy Markdown
Member Author

@AlexPeshkoff can you test it then?

@dyemanov

Copy link
Copy Markdown
Member

Tested with gcc 4.8.2, the branch compiles fine.

@AlexPeshkoff

Copy link
Copy Markdown
Member

With 4.9.3 it alsi builds fine.
I think it's time to merge it.

@aafemt

aafemt commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

I think it's time to merge it.

If you have time, merge PR #15 first.

@asfernandes asfernandes merged commit c6d9135 into master Sep 22, 2016
@asfernandes asfernandes deleted the work/c++11 branch October 4, 2016 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants