chore: bump dev tooling to modern versions by tyler-reitz · Pull Request #713 · FirebaseExtended/reactfire

tyler-reitz · 2026-06-17T17:20:10Z

Summary

TypeScript `^5.1.3` → `^6.0.3`
Vitest `^0.32.2` → `^4.1.9`, `@vitest/ui` → `^4.1.9`
Vite `^4.3.9` → `^8.0.16`, `@vitejs/plugin-react` `^4.0.1` → `^6.0.2`
`@rollup/plugin-typescript` `^11.1.1` → `^12.3.0`
Prettier `^2.8.8` → `^3.8.4`
typedoc `^0.24.8` → `^0.28.19`, typedoc-plugin-markdown `^3.15.3` → `^4.12.0` (required for TypeScript 6 compatibility)
`tsconfig.json`: `moduleResolution: "node"` + `ignoreDeprecations: "6.0"` (bundler resolution breaks rxfire subpath imports — keeping node resolution for now; tracked in Migrate moduleResolution from "node" to "bundler" and remove ignoreDeprecations #723)
GitHub Actions: bump checkout, setup-node, upload-artifact, download-artifact, cache to v4
Node: CI matrix 20/22 → 22/24; build/publish/docs jobs → Node 24
`firebase-tools`: `^12.4.0` → `^15.22.3`
`firebase` (devDep): `^9.23.0` → `^11.10.0` (required for firebase-tools 15 emulator compatibility; 12.x blocked by rxfire peer dep)
`rxfire`: `^6.0.3` → `^6.1.0` (supports firebase 11.x peer dep)
`functions/`: migrate to Gen 2 API, firebase-admin `^11` → `^13`, firebase-functions `^4` → `^7`, engines node 18 → 22
Fix TypeScript 6 type errors: `NodeJS.Timeout` → `ReturnType`, declare `process.env`, `as ObservableStatus` assertions in firestore.tsx

Test plan

`tsc --noEmit` passes clean
`npm run build` succeeds (pre-existing MISSING_GLOBAL_NAME warnings unchanged)
`npm run test:useObservable` — 14/14 pass
`npm run test:firebaseApp` — 7/7 pass
`npm test` (full emulator suite) — 59/59 pass on Node 24 locally; Node 22 + 24 pass in CI

google-cla · 2026-06-17T17:20:35Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request updates several devDependencies in package.json and adds the ignoreDeprecations setting to tsconfig.json. The feedback highlights that multiple updated dependency versions (such as typescript, vite, vitest, and prettier) do not exist on the public npm registry, which would cause installation failures. Additionally, the ignoreDeprecations value in tsconfig.json should be corrected from "6.0" to "5.0" to properly suppress the legacy module resolution deprecation warning.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-17T17:21:42Z

    "noUnusedParameters": true,
-    // use Node's module resolution algorithm, instead of the legacy TS one
    "moduleResolution": "node",
+    "ignoreDeprecations": "6.0",


The ignoreDeprecations: "6.0" setting is incorrect because TypeScript 6.0 does not exist, and the deprecation of the legacy node (Node 10) module resolution was introduced in TypeScript 5.0. To suppress the deprecation warning, you should specify "5.0".

Suggested change

"ignoreDeprecations": "6.0",

"ignoreDeprecations": "5.0",

Can you please file an issue to investigate what we need to fix so that we can remove this option?

Filed #723. Also fixed the value from "6.0" to "5.0" while I was in here.

Actually reverting that -- with TypeScript 6, the node10 deprecation warning requires "6.0" to silence it, not "5.0". So the original value was correct for our setup. The tracking issue (#723) still stands.

tyler-reitz · 2026-06-17T22:01:53Z

Note on the failing test checks: the 'throws an error if no observableId is provided' test failure in CI appears to be pre-existing and specific to the full emulator test suite environment — the test passes locally with both the old and new Vitest versions (14/14). Flagging so this doesn't block review.

Upgrade TypeScript 5→6, Vitest 0.32→4.1, Vite 4→8, @vitejs/plugin-react 4→6, @rollup/plugin-typescript 11→12, and Prettier 2→3. Add ignoreDeprecations:"6.0" to tsconfig to silence the node moduleResolution deprecation warning (rxfire subpath exports lack a types condition so bundler resolution breaks them).

typedoc@0.24.8 only supports TypeScript up to 5.1.x; upgrading to 0.28.19 which supports 6.0.x. Also bumps typedoc-plugin-markdown from 3.15.3 to 4.12.0 to match the new typedoc peer requirement.

Vite 8 (via rolldown) requires Node 20+ for styleText from node:util. Update CI test matrix to Node 20/22 and build/publish jobs to Node 20. Node 18 reached EOL in April 2025. Also fix the "throws an error if no observableId is provided" test which was failing under Vitest 4. React 18 dispatches a window error event when a component throws during render, even when the throw is caught by expect().toThrow(). Vitest 4 surfaces these as uncaught errors. Fix by adding a window error listener that calls preventDefault(), and match on the error message via expect.objectContaining to account for React setting _suppressLogging on the error object. Also widen the firebase peerDependency to accept v10/v11/v12.

jhuleatt · 2026-06-26T16:48:44Z

    strategy:
      matrix:
-        node: ["18", "20"]
+        node: ["20", "22"]


let's jump to 22 and 24: https://nodejs.org/en/about/previous-releases

Suggested change

node: ["20", "22"]

node: ["22", "24"]

Done, updated to ["22", "24"].

jhuleatt · 2026-06-26T16:49:01Z

+        uses: actions/setup-node@v4
        with:
-          node-version: '18'
+          node-version: '20'


Suggested change

node-version: '20'

node-version: '24'

Updated to 24.

jhuleatt · 2026-06-26T16:49:12Z

-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
        with:
          node-version: '18'


Suggested change

node-version: '18'

node-version: '24'

Updated to 24.

jhuleatt · 2026-06-26T16:49:42Z

+        uses: actions/setup-node@v4
        with:
-          node-version: '18'
+          node-version: '20'


Suggested change

node-version: '20'

node-version: '24'

Updated to 24.

jhuleatt · 2026-06-26T16:52:11Z

    "noUnusedParameters": true,
-    // use Node's module resolution algorithm, instead of the legacy TS one
    "moduleResolution": "node",
+    "ignoreDeprecations": "6.0",


Can you please file an issue to investigate what we need to fix so that we can remove this option?

jhuleatt · 2026-06-26T18:40:53Z

I wonder if the CI is failing because firebase-tools is so old. Could you try to update to 15.22.3?

Updated to ^15.22.3 -- will see if it clears the CI failures.

…Deprecations - CI matrix: Node 20/22 -> 22/24; build/publish/docs jobs: node 20/18 -> 24 - firebase-tools: ^12.4.0 -> ^15.22.3 (may fix emulator test CI failures) - tsconfig: fix ignoreDeprecations value from "6.0" to "5.0" (tracked in FirebaseExtended#723)

…precation)

…ed links)

…-tools 15 - firebase devDep: ^9.23.0 -> ^12.15.0 (required for firebase-tools 15 emulator compatibility) - functions/index.js: migrate from Gen 1 to Gen 2 API (firebase-functions v7) - functions: firebase-admin ^11 -> ^13, firebase-functions ^4 -> ^7 - functions: engines.node 18 -> 22

…nd firebase-tools 15 emulator)

- SuspenseSubject: NodeJS.Timeout -> ReturnType<typeof setTimeout> - firebaseApp: declare process.env for Vite define replacement - firestore: type assert useObservable return as ObservableStatus<T>

tyler-reitz · 2026-06-26T21:16:54Z

All CI checks now passing. Summary of changes made during review:

Node bumped to 22/24 per your suggestion
firebase-tools bumped to 15.22.3, which required also bumping firebase devDep to 11.x (12.x blocked by rxfire's peer dep) and migrating the test functions to the Gen 2 API
Full emulator test suite now passes on Node 22 and 24
Fixed 3 TypeScript 6 type errors surfaced by the tighter checker (tracked in Migrate moduleResolution from "node" to "bundler" and remove ignoreDeprecations #723)

gemini-code-assist Bot reviewed Jun 17, 2026

View reviewed changes

tyler-reitz force-pushed the chore/bump-devdependencies branch 3 times, most recently from 01eebed to c995882 Compare June 18, 2026 18:31

tyler-reitz added 4 commits June 25, 2026 13:08

chore: bump typedoc to 0.28.x for TypeScript 6 compatibility

94d5175

typedoc@0.24.8 only supports TypeScript up to 5.1.x; upgrading to 0.28.19 which supports 6.0.x. Also bumps typedoc-plugin-markdown from 3.15.3 to 4.12.0 to match the new typedoc peer requirement.

chore: bump GitHub Actions to latest versions

2787bda

tyler-reitz force-pushed the chore/bump-devdependencies branch from c995882 to 74bb15b Compare June 25, 2026 20:09

jhuleatt reviewed Jun 26, 2026

View reviewed changes

tyler-reitz added 9 commits June 26, 2026 13:01

chore: update package-lock.json for firebase-tools bump to 15.22.3

5887bad

ci: add Java 21 setup step (required by firebase-tools 15)

fa7658e

chore: revert ignoreDeprecations to "6.0" (required for TS6 node10 de…

b4df1ff

…precation)

chore: regenerate reference docs with upstream remote (FirebaseExtend…

cd9bf05

…ed links)

chore: use firebase 11.x as devDep (compatible with rxfire peer dep a…

f9a13b7

…nd firebase-tools 15 emulator)

chore: bump rxfire to 6.1.0 (supports firebase 11.x peer dep)

cbe9520

fix: resolve TypeScript 6 type errors

dd061ef

- SuspenseSubject: NodeJS.Timeout -> ReturnType<typeof setTimeout> - firebaseApp: declare process.env for Vite define replacement - firestore: type assert useObservable return as ObservableStatus<T>

Uh oh!

Conversation

tyler-reitz commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

google-cla Bot commented Jun 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tyler-reitz commented Jun 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tyler-reitz commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tyler-reitz commented Jun 17, 2026 •

edited

Loading