-
Notifications
You must be signed in to change notification settings - Fork 403
useAnalytics missing in ReactFire v4 #429 #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jhuleatt
merged 7 commits into
FirebaseExtended:main
from
shiiinji:feature_v4_useAnalytics
Aug 26, 2021
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
135ed70
add declaration of useAnalytics
shiiinji c971ab4
add an example for Analytics
shiiinji 9779afe
update docs/use.md for reactfire 4.0 and firebase 9.0 on Log Page Vie…
shiiinji 44d70fc
Update docs/use.md
shiiinji 40ef01c
Update docs/use.md
shiiinji 6953115
Update example/withoutSuspense/Analytics.tsx
shiiinji d000464
regenerate reference docs
shiiinji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import * as React from 'react' | ||
| import { AnalyticsProvider, useFirebaseApp, useAnalytics } from 'reactfire'; | ||
| import { getAnalytics, logEvent } from 'firebase/analytics' | ||
|
|
||
|
|
||
| function MyPageViewLogger() { | ||
| const analytics = useAnalytics() | ||
|
|
||
| React.useEffect(() => { | ||
| logEvent(analytics, 'page_view') | ||
| }, [location.pathname]) | ||
|
shiiinji marked this conversation as resolved.
Outdated
|
||
|
|
||
| return null | ||
| } | ||
|
|
||
| export function Analytics() { | ||
| const app = useFirebaseApp(); | ||
| return ( | ||
| <AnalyticsProvider sdk={getAnalytics(app)}> | ||
| <MyPageViewLogger /> | ||
| </AnalyticsProvider> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.