Let GroupHeader Title be overridden by TitleAttribute when the group is a ToggleGroup - #11658
Open
QuackCola wants to merge 1 commit into
Open
Let GroupHeader Title be overridden by TitleAttribute when the group is a ToggleGroup #11658QuackCola wants to merge 1 commit into
QuackCola wants to merge 1 commit into
Conversation
Will default to 'groupName' if the 'titleAttr.Value' happens to be null or just an empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr adds a basic check so that a ToggleGroup can have its title overridden.
Motivation & Context
Without this simple patch you cant use ToggleGroup name that has space's since it relies on the name being the exact match to the accompanying bool property.
Implementation Details
Simple Check if
TitleAttributeis present along with an additional check to fallback to thegroupNameif necessary.Checklist