Add notification.Add - #2434
Open
Zaurzo wants to merge 7 commits into
Open
Conversation
Contributor
|
IMHO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new function
Addto the notification library. This serves as a more flexible version ofAddLegacy.Returns the ID of the added notice to use with
notification.Kill(if you need to)Unlike
AddLegacy, this isn't restricted to a preset group of icons, and takes a material path, allowing you to give the notice any icon that you want. Acolorargument is added to change the text color for more customizability. Additionally, the name is shorter, and removes any potential confusion with the nameAddLegacy.I also cleaned up the code a bit and reduced some code copy-paste.
I originally made a PR (#1967) that added a function that would add custom types to use with
AddLegacy, but in hindsight, I think it wasn't a very good idea. This PR serves as an improved version of my old one.Demonstration