Skip to content

fix(input-time-picker): emit change event when clearing meridiem - #13836

Merged
eriklharper merged 1 commit into
devfrom
eriklharper/12889-input-time-picker-meridiem-clearing-not-emitting
Feb 5, 2026
Merged

fix(input-time-picker): emit change event when clearing meridiem#13836
eriklharper merged 1 commit into
devfrom
eriklharper/12889-input-time-picker-meridiem-clearing-not-emitting

Conversation

@eriklharper

Copy link
Copy Markdown
Contributor

Related Issue: #12889

Summary

This PR fixes an issue when clearing the meridiem field (which subsequently clears the whole value), a change event failed to fire.

@eriklharper
eriklharper requested a review from jcfranco February 3, 2026 17:58
@github-actions github-actions Bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 3, 2026

@driskull driskull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@isaacbraun isaacbraun added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 3, 2026
@eriklharper
eriklharper merged commit 3dc347c into dev Feb 5, 2026
15 checks passed
@eriklharper
eriklharper deleted the eriklharper/12889-input-time-picker-meridiem-clearing-not-emitting branch February 5, 2026 19:19
@github-actions github-actions Bot added this to the 2026-03-25 - Mar Milestone milestone Feb 5, 2026
isaacbraun pushed a commit that referenced this pull request Feb 12, 2026
)

**Related Issue:** #12889

## Summary

This PR fixes an issue when clearing the meridiem field (which
subsequently clears the whole value), a change event failed to fire.
isaacbraun pushed a commit that referenced this pull request Feb 12, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 5.0.1</summary>

##
[5.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@5.0.0...@esri/calcite-components@5.0.1)
(2026-02-12)


### Bug Fixes

* **dialog:** Honor `--calcite-dialog-offset-y` regardless of fullscreen
behavior
([#13903](#13903))
([b3a4215](b3a4215))
* **input-date-picker:** Allow configuring range calendar background
color via token
([#13873](#13873))
([41481c2](41481c2))
* **input-time-picker:** Emit change event when clearing meridiem
([#13836](#13836))
([c0b2fc5](c0b2fc5))
* **input-time-picker:** Sync popup value with input when directly
cleared
([#13875](#13875))
([611234a](611234a))
* **tab-title:** Switch order of preferred and deprecated icon color
variables
([#13889](#13889))
([1459c8c](1459c8c))
* **tree-item:** Restore selection icon to bullet when
`selection-mode='single'|'single-persist'|'children'`
([#13915](#13915))
([c8e6f4f](c8e6f4f))
</details>

<details><summary>@esri/calcite-components-react: 5.0.1</summary>

##
[5.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@5.0.0...@esri/calcite-components-react@5.0.1)
(2026-02-12)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 5.0.0 to 5.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
isaacbraun pushed a commit that referenced this pull request Feb 12, 2026
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 5.0.1</summary>

[5.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@5.0.0...@esri/calcite-components@5.0.1)
(2026-02-12)

* **dialog:** Honor `--calcite-dialog-offset-y` regardless of fullscreen
behavior
([#13903](#13903))
([b3a4215](b3a4215))
* **input-date-picker:** Allow configuring range calendar background
color via token
([#13873](#13873))
([41481c2](41481c2))
* **input-time-picker:** Emit change event when clearing meridiem
([#13836](#13836))
([c0b2fc5](c0b2fc5))
* **input-time-picker:** Sync popup value with input when directly
cleared
([#13875](#13875))
([611234a](611234a))
* **tab-title:** Switch order of preferred and deprecated icon color
variables
([#13889](#13889))
([1459c8c](1459c8c))
* **tree-item:** Restore selection icon to bullet when
`selection-mode='single'|'single-persist'|'children'`
([#13915](#13915))
([c8e6f4f](c8e6f4f))
</details>

<details><summary>@esri/calcite-components-react: 5.0.1</summary>

[5.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@5.0.0...@esri/calcite-components-react@5.0.1)
(2026-02-12)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 5.0.0 to 5.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
isaacbraun added a commit that referenced this pull request Feb 12, 2026
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 5.0.1</summary>


[5.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@5.0.0...@esri/calcite-components@5.0.1)
(2026-02-12)

* **dialog:** Honor `--calcite-dialog-offset-y` regardless of fullscreen
behavior
([#13903](#13903))

([b3a4215](b3a4215))
* **input-date-picker:** Allow configuring range calendar background
color via token
([#13873](#13873))

([41481c2](41481c2))
* **input-time-picker:** Emit change event when clearing meridiem
([#13836](#13836))

([c0b2fc5](c0b2fc5))
* **input-time-picker:** Sync popup value with input when directly
cleared
([#13875](#13875))

([611234a](611234a))
* **tab-title:** Switch order of preferred and deprecated icon color
variables
([#13889](#13889))

([1459c8c](1459c8c))
* **tree-item:** Restore selection icon to bullet when
`selection-mode='single'|'single-persist'|'children'`
([#13915](#13915))

([c8e6f4f](c8e6f4f))
</details>

<details><summary>@esri/calcite-components-react: 5.0.1</summary>


[5.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@5.0.0...@esri/calcite-components-react@5.0.1)
(2026-02-12)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 5.0.0 to 5.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants