This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Use the standard trick for BuildAbortionStage - #4
Open
jglick wants to merge 1 commit into
Open
Conversation
|
@jglick if you see here: I think most of these can be deleted, but I would like some tests around how this works if that's okay 👍 |
Author
Your test system is over my head I am afraid. The actual Pipeline code is covered by jenkinsci/pipeline-milestone-step-plugin#12. |
Author
|
jenkinsci/workflow-job-plugin#200 has been released; I would recommend that now instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoids using non-sandbox-friendly methods to abort previous builds, using the standard workaround for JENKINS-43353. (Requires the
pipeline-milestone-stepplugin.) jenkinsci/workflow-job-plugin#200 would be nicer.Submitter's Pledge
Reviewers, I have verified the following to the best of my knowledge:
CHANGELOG.mdwith the new target version (or with theUnreleasedtag) and updated the version comparison url in the file.README.mdat the repo root and all of the applicableREADME.mdfiles underdocs/**along with necessary version change for code samples in those docs where applicable.Review Recommendation
Not sure whether this is tested realistically.