Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

Use the standard trick for BuildAbortionStage - #4

Open
jglick wants to merge 1 commit into
EliLillyCo:masterfrom
jglick:BuildAbortionStage
Open

Use the standard trick for BuildAbortionStage#4
jglick wants to merge 1 commit into
EliLillyCo:masterfrom
jglick:BuildAbortionStage

Conversation

@jglick

@jglick jglick commented Jun 30, 2021

Copy link
Copy Markdown

Summary

Avoids using non-sandbox-friendly methods to abort previous builds, using the standard workaround for JENKINS-43353. (Requires the pipeline-milestone-step plugin.) jenkinsci/workflow-job-plugin#200 would be nicer.

Submitter's Pledge

Reviewers, I have verified the following to the best of my knowledge:

  • I have added unit test cases for the changes where applicable.
  • I have updated CHANGELOG.md with the new target version (or with the Unreleased tag) and updated the version comparison url in the file.
  • I have updated documentation in README.md at the repo root and all of the applicable README.md files under docs/** along with necessary version change for code samples in those docs where applicable.
  • I have read and fully understand the process for submitting a pull request to the codebase.

Review Recommendation

Not sure whether this is tested realistically.

@jglick
jglick requested a review from a team as a code owner June 30, 2021 23:11
@NickLiffen

Copy link
Copy Markdown

@jglick if you see here:

https://github.com/EliLillyCo/jenkinsdsl/blob/e6ee83976ddb29cd46d28fee63b8b4ccd7c59930/test/src/com/lilly/cirrus/jenkinsdsl/core/BuildAbortionStageSpec.groovy

I think most of these can be deleted, but I would like some tests around how this works if that's okay 👍

@jglick

jglick commented Jul 1, 2021

Copy link
Copy Markdown
Author

I would like some tests around how this works

Your test system is over my head I am afraid. The actual Pipeline code is covered by jenkinsci/pipeline-milestone-step-plugin#12.

@jglick

jglick commented Oct 12, 2021

Copy link
Copy Markdown
Author

jenkinsci/workflow-job-plugin#200 has been released; I would recommend that now instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants