-
Notifications
You must be signed in to change notification settings - Fork 0
changed workflow to use extern shellcheck #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,12 +11,7 @@ on: | |||||
| - synchronize | ||||||
|
|
||||||
| jobs: | ||||||
| check-shell-syntax: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Checkout code | ||||||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | ||||||
| - name: Install shellcheck | ||||||
| run: sudo apt-get install shellcheck | ||||||
| - name: Run shellcheck | ||||||
| run: shellcheck `find ./ -type f -name "*lib"` | ||||||
| call-shellcheck-workflow: | ||||||
| uses: Element-Logic/github-workflows/.github/workflows/shellcheck.yml@main | ||||||
| with: | ||||||
| arguments: "`find ./ -type f -name '*lib'`" | ||||||
|
||||||
| arguments: "`find ./ -type f -name '*lib'`" | |
| arguments: "**/*lib" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
@mainfor the external workflow reference is less secure than pinning to a specific commit SHA. The original workflow used a pinned SHA (actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683). Consider using a specific commit SHA or at least a version tag to prevent unexpected changes if the external workflow is modified.