Skip to content

Add restartPlugin function to EdgeProvider and PluginView to regenera…#1853

Merged
swansontec merged 1 commit into
developfrom
sfncook/restartPlugin
Apr 1, 2020
Merged

Add restartPlugin function to EdgeProvider and PluginView to regenera…#1853
swansontec merged 1 commit into
developfrom
sfncook/restartPlugin

Conversation

@sfncook

@sfncook sfncook commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

…te webView component on demand

PR Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS Tablet
  • Tested on small Android
  • n/a

@swansontec swansontec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a few tiny nit-picks.

Comment thread src/components/scenes/PluginViewScene.js Outdated
Comment thread src/components/scenes/PluginViewScene.js Outdated
Comment thread src/components/scenes/PluginViewScene.js Outdated
@swansontec swansontec force-pushed the sfncook/restartPlugin branch from 33e6b55 to 546c961 Compare April 1, 2020 23:16
@swansontec

Copy link
Copy Markdown
Contributor

Resolved some conflicts, and now this is seems good to merge!

@swansontec swansontec merged commit efcabb9 into develop Apr 1, 2020
@swansontec swansontec deleted the sfncook/restartPlugin branch April 1, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants