Allow num_regression to accept array-like inputs - #45
Merged
Conversation
nicoddemus
requested changes
Jan 27, 2021
nicoddemus
left a comment
nicoddemus
left a comment
Member
There was a problem hiding this comment.
This is looking great already, thanks @jpn-- for the contribution!
Please take a look at my two minor comments. 👍
tadeu
approved these changes
Jan 27, 2021
tadeu
left a comment
tadeu
left a comment
Contributor
There was a problem hiding this comment.
Awesome, thanks for this improvement :)
nicoddemus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, the num_regression fixture only accepts actual 1-d numpy arrays. It would be convenient if it would also accept array-like inputs, including list of numbers and scalars. It's easy enough to convert them in my tests, but it's also super easy and suitably concise to make the change here. I'm not able to simply use the regular data_regression fixture in cases where the values are floats that might have a tiny bit of variance. The num_regression fixture with its tolerance control is exactly what I want in that instance.