Add service check to java dogstatsd client, add test#1
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
Hmm, I thought I had ported that from elsewhere, but I can't seem to find where it came from. I'll remove it here and in the dd-agent PR.
There was a problem hiding this comment.
message could be Null, If it is required, I would make it part of the constructor and throw an exception if it fails, if it is optional I would return null or empty string here, whichever makes more sense.
There was a problem hiding this comment.
I just saw that you check below if it is null or not, nvm.
Contributor
Author
|
Ready as soon as DataDog/dd-agent#1170 is released. |
2 tasks
|
@yannmh Can you review and merge to maven central? |
wang-arthur
force-pushed
the
add_service_checks
branch
from
103d96f to
b7c4608
Compare
|
LGTM 👍 |
wang-arthur
pushed a commit
that referenced
this pull request
Mar 12, 2015
Add service check to java dogstatsd client, add test
masci
pushed a commit
that referenced
this pull request
Jul 1, 2016
Externalise DNS resolution on the NonBlockingStatsDClient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.