Skip to content

Fix java9 module smoke test jlink on Gradle 9.5.1#11489

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/gradle9-java9-modules-jlink
May 28, 2026
Merged

Fix java9 module smoke test jlink on Gradle 9.5.1#11489
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/gradle9-java9-modules-jlink

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented May 28, 2026 •
edited
Loading

What Does This Do

Gradle 9.x no longer resolves the bare exec {} call from the :dd-smoke-tests:java9-modules:test doFirst action. This moves the jlink invocation to providers.exec, keeping the custom runtime-image setup on a Gradle-supported execution API.

Part of #10402 and #11272.

Motivation

Compatibility for Gradle 9.

Additional Notes

Validation used while preparing this branch:

  • ./gradlew :dd-smoke-tests:java9-modules:test -PtestJvm=11
  • ./gradlew :dd-smoke-tests:java9-modules:test -PtestJvm=17
  • ./gradlew :dd-smoke-tests:java9-modules:test -PtestJvm=21

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@bric3
fix(smoke-tests): use provider exec for java9 jlink
368fd5a 
Gradle 9.5.1 no longer resolves the bare exec method from
the java9-modules Test.doFirst action. Use ProviderFactory.exec
to run jlink through Gradle's provider API so the smoke test
works on the Gradle 9.5.1 CI pipeline.
@bric3 bric3 added type: bug Bug report and fix comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels May 28, 2026 — with ChatGPT Codex Connector
This was referenced May 28, 2026
Draft
Open
@bric3 bric3 marked this pull request as ready for review May 28, 2026 13:04
@bric3 bric3 requested a review from a team as a code owner May 28, 2026 13:04
@bric3 bric3 requested a review from mhlidd May 28, 2026 13:04
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026 •
edited
Loading

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Startup Time

Scenario This PR master Change
insecure-bank / iast 13,946 ms 13,901 ms +0.3%
insecure-bank / tracing 12,856 ms 12,953 ms -0.7%
petclinic / appsec 16,537 ms 16,419 ms +0.7%
petclinic / iast 16,419 ms 16,553 ms -0.8%
petclinic / profiling 16,465 ms 16,596 ms -0.8%
petclinic / tracing 15,770 ms 15,648 ms +0.8%

Commit: 9a2a98cc · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3 bric3 added this pull request to the merge queue May 28, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 28, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-05-28 13:55:31 UTC ℹ️ Start processing command /merge

2026-05-28 13:55:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-28 15:56:14 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 106114704890939053 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented May 28, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 28, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-05-28 16:16:04 UTC ℹ️ Start processing command /merge

2026-05-28 16:16:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-28 17:02:03 UTC ❌ MergeQueue: This merge request was updated

This PR is rejected because it was updated

@datadog-prod-us1-3

This comment has been minimized.

Sign in to view
@bric3 bric3 added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 28, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-05-28 19:21:01 UTC ℹ️ Start processing command /merge

2026-05-28 19:21:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-28 20:29:38 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 672972d into master May 28, 2026
758 of 761 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/gradle9-java9-modules-jlink branch May 28, 2026 20:29
@github-actions github-actions Bot added this to the 1.63.0 milestone May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

@mhlidd mhlidd Awaiting requested review from mhlidd mhlidd is a code owner automatically assigned from DataDog/apm-java

@sarahchen6 sarahchen6 Awaiting requested review from sarahchen6

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bric3 @AlexeyKuznetsov-DD