Merge bitcoin/bitcoin#26773: doc: FreeBSD build doc updates to reflect removal of install_db4.sh - #298
Conversation
…l of install_db4.sh c572eae update the freebsd build doc to reflect recent changes to DB4 install process (Murray Nesbitt) Pull request description: This PR introduces documentation changes needed to keep up with bitcoin#26834. ACKs for top commit: fanquake: ACK c572eae - have not tested, but looks ok. Tree-SHA512: 42a79e7b45834916b1b738db524b51b9ff4fde8348ba66fc331ff6603532dd9fce73ea392eef97d31112326c6d60ec2c5c7c29e66aab33aaf846aab8aea1d1aa
WalkthroughRewrites FreeBSD build documentation to switch legacy wallet guidance from Berkeley DB 5 to Berkeley DB 4.8, add instructions to build DB 4.8 via depends, expose installation path, require setting BDB_PREFIX, and reorganize configuration examples for GUI and non-GUI wallet scenarios. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)doc/**📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📓 Common learnings🪛 markdownlint-cli2 (0.18.1)doc/build-freebsd.md42-42: Fenced code blocks should have a language specified (MD040, fenced-code-language) 48-48: Fenced code blocks should have a language specified (MD040, fenced-code-language) 54-54: Fenced code blocks should have a language specified (MD040, fenced-code-language) 58-58: Fenced code blocks should have a language specified (MD040, fenced-code-language) 108-108: Heading levels should only increment by one level at a time (MD001, heading-increment) 108-108: Headings should be surrounded by blank lines (MD022, blanks-around-headings) 110-110: Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) 115-115: Headings should be surrounded by blank lines (MD022, blanks-around-headings) 118-118: Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) 🔇 Additional comments (2)
|
✅ Backport Verification SuccessfulNo issues found! This backport is complete and faithful to the original Bitcoin change. Original Bitcoin commit: Verification Details:
Reviewer Feedback Analysis:PastaPastaPasta comments reviewed: 0 No reviewer feedback to address - this PR is ready for review. This PR is ready for merge. ✅ |
|
|
||
| ##### Descriptor Wallet and GUI: | ||
| This explicitly enables the GUI and disables legacy wallet support, assuming `sqlite` and `qt` are installed. | ||
| ```bash | ||
| ./autogen.sh | ||
| ./configure --without-bdb --with-gui=yes MAKE=gmake | ||
| ``` | ||
|
|
||
| ##### Descriptor & Legacy Wallet. No GUI: | ||
| This enables support for both wallet types and disables the GUI, assuming | ||
| `sqlite3` and `db4` are both installed. | ||
| ```bash | ||
| ./autogen.sh | ||
| ./configure --with-gui=no --with-incompatible-bdb \ | ||
| BDB_LIBS="-ldb_cxx-5" \ | ||
| BDB_CFLAGS="-I/usr/local/include/db5" \ | ||
| ./configure --with-gui=no \ | ||
| BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" \ | ||
| BDB_CFLAGS="-I${BDB_PREFIX}/include" \ |
There was a problem hiding this comment.
justify this divergence from the upstream changes
✅ Backport Verification SuccessfulNo issues found! This backport is complete and faithful to the original Bitcoin change. Original Bitcoin commit: Reviewer Feedback Response
This PR is ready for merge. ✅ |
- Removed redundant 'Wallet (only SQlite) and GUI Support' section - This section was identical to 'Descriptor Wallet and GUI' section - Matches Bitcoin's documentation structure with 3 configuration examples - Addresses reviewer feedback about divergence from upstream
Validation Fixes AppliedI've identified and fixed a documentation issue in this PR: Issue FoundThe backport introduced a redundant configuration section. The PR added Bitcoin's standard configuration examples but didn't remove the old Dash-specific section that was functionally identical. Duplicate sections:
Both sections had identical configure commands ( Fix Applied✅ Removed the redundant The documentation now matches Bitcoin's structure with 3 configuration examples:
This addresses @PastaPastaPasta's comment requesting justification for the divergence from upstream. The fix eliminates the divergence by removing the duplicate section. Next Steps
Applied by verification agent |
Verification Complete ✅This PR has been verified and approved for the following reasons: Changes Summary
Validation✅ Backport Faithful: Changes correctly adapt Bitcoin's updates:
✅ Reviewer Feedback Addressed: Validation commit (b6fdaee) removed duplicate configuration section that diverged from Bitcoin's structure ✅ Lint: Passed CI Status Note
ConclusionThis is a faithful backport of Bitcoin PR bitcoin#26773 that correctly documents the FreeBSD build process changes. The validation fixes properly addressed reviewer concerns. The PR is ready to merge. cc: @PastaPastaPasta - The divergence you identified has been corrected. |
Backports bitcoin#26773
Original commit: 75f0e0b
Backported from Bitcoin Core v0.25
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.