Skip to content

Patch inactive user issue in V2 API - #3610

Open
momo3404 wants to merge 3 commits into
developmentfrom
momo/v2-api-inactive-user-patch
Open

Patch inactive user issue in V2 API#3610
momo3404 wants to merge 3 commits into
developmentfrom
momo/v2-api-inactive-user-patch

Conversation

@momo3404

Copy link
Copy Markdown
Collaborator

Changes proposed in this PR:

  • Add authorize_resource_owner function to base_api_controller that checks if user is active and present before authorization.
  • Create base_controller_spec for V2 base_api_controller

- Function checks if resource owner is active and present before authorization, and returns error if not
- Move code assigning resource_owner to this new function for better readability
@github-actions

Copy link
Copy Markdown
</tr>
1 Error
🚫

Please include a CHANGELOG entry.

You can find it at [CHANGELOG.md](https://github.com/DMPRoadmap/roadmap/blob/main/CHANGELOG.md).
1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior. \n
Ignore this warning if the PR ONLY contains translation.io synced updates.

Generated by 🚫 Danger

@aaronskiba

Copy link
Copy Markdown
Contributor

One test is breaking and it must be because you are calling render_error, but this repo does not yet define it (DMP Assistant added it here: portagenetwork@b1bd290).

@momo3404
momo3404 force-pushed the momo/v2-api-inactive-user-patch branch from 3405d6f to f6f42cc Compare August 11, 2026 19:55
@momo3404
momo3404 force-pushed the momo/v2-api-inactive-user-patch branch from bd50e66 to d78fe3a Compare August 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants