Skip to content

Fix handling of template.visibility #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronskiba wants to merge 1 commit into from
Closed

Fix handling of template.visibility #3420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/views/org_admin/templates/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
placement: 'right' }%>
<div class="form-check">
<%= f.label(:visibility) do %>
<%= f.check_box(:visibility, checked: f.object.visibility == 'organisationally_visible') %>
<%= f.check_box(:visibility,
{},
f.object.class.visibilities[:organisationally_visible],
f.object.class.visibilities[:publicly_visible])
%>

<%= _('for internal %{org_name} use only') % { org_name: f.object.org.name } %>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/org_admin/templates/_show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<!-- If the Org is a funder and another org type then allow then to set the visibility -->
<dt><%= _('Visibility') %></dt>
<dd>
<% if template.visibility == 'organisationally_visible' %>
<% if template.organisationally_visible? %>
<%= _('for internal %{org_name} use only') % {org_name: template.org.name} %>
<% else %>
<%= _('available to the public') + (template.published? ? '' : ' (once published)') %>
Expand Down