Ignore classes derived from AssetFilterAsset in adding asset filter menu#55
Merged
Haruma-K merged 1 commit intoApr 2, 2024
Conversation
Haruma-K
self-requested a review
April 2, 2024 07:55
Haruma-K
approved these changes
Apr 2, 2024
Haruma-K
left a comment
Contributor
There was a problem hiding this comment.
ありがとうございます!
マージしてリリースします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
アセットフィルタの追加メニューにおいて、
AssetFilterAssetを継承して実装されたカスタムのアセットフィルタを表示しないようにします。詳細
AssetFilterAssetを継承してカスタムのアセットフィルタを実装すると、アセットフィルタを追加する際のメニューに項目が追加されますが、こちらを選ぶと例外が発生しアセットフィルタの追加ができませんでした。READMEでは、直接カスタムアセットフィルタを追加するのではなく、
CustomAssetFilterを追加してからそこにScirptableObjectとしてアサインするようになっていて、こちらの手順は正しく機能します。このPRでは、
AssetFilterAssetの派生クラスはアセットフィルタの追加メニューに表示しないようにして、上記手順で混乱するのを防止します。