Publish via workflow with trusted publishing - #3915
Merged
Merged
Conversation
nstepien
commented
Nov 21, 2025
| run: npm publish | ||
|
|
||
| - name: Push commit and tag | ||
| run: git push origin main --follow-tags |
Collaborator
Author
There was a problem hiding this comment.
I will have to double-check our branch rules, we need to allow directly pushing to main.
| run: git push origin main --follow-tags | ||
|
|
||
| - name: Create GitHub Release | ||
| run: gh release create v${{ inputs.version }} --title "v${{ inputs.version }}" --generate-notes |
Collaborator
Author
There was a problem hiding this comment.
We'll create immutable releases now, we'll have to write changelogs manually.
We can improve this in the future to automatically add changelogs from files, but this will do for now.
nstepien
marked this pull request as ready for review
November 21, 2025 14:56
amanmahajan7
approved these changes
Nov 26, 2025
amanmahajan7
left a comment
amanmahajan7
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Have we restricted token access?
https://docs.npmjs.com/trusted-publishers#recommended-restrict-token-access-when-using-trusted-publishers
Collaborator
Author
Will do so after we confirm this process works |
Collaborator
Author
Publishing access is now restricted 👍 |
royue
pushed a commit
to royue/react-data-grid
that referenced
this pull request
Dec 17, 2025
* Publish via workflow with trusted publishing * update actions/checkout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.npmjs.com/trusted-publishers