Set drag column image - #3783
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3783 +/- ##
=======================================
Coverage 98.79% 98.80%
=======================================
Files 46 46
Lines 3497 3507 +10
Branches 763 764 +1
=======================================
+ Hits 3455 3465 +10
Misses 42 42
🚀 New features to boost your workflow:
|
amanmahajan7
commented
May 15, 2025
| const cellDragging = css` | ||
| opacity: 0.5; | ||
| @layer rdg.HeaderCell { | ||
| background-color: var(--rdg-header-draggable-background-color); |
Collaborator
Author
There was a problem hiding this comment.
Kept the same style as cell over for now. We cannot use opacity as we are using a custom drag image
| const dragImage = event.currentTarget.cloneNode(true) as HTMLDivElement; | ||
| dragImage.classList.add(dragImageClassname); | ||
| dragImage.id = dragImageId; | ||
| event.currentTarget.parentElement!.insertBefore(dragImage, event.currentTarget); |
Collaborator
Author
There was a problem hiding this comment.
This way the element is behind the column
| onDragEnd | ||
| }; | ||
|
|
||
| if (draggedColumnKey !== undefined && draggedColumnKey !== column.key) { |
Collaborator
Author
There was a problem hiding this comment.
Now we won't fire these events if external item is dragged over
| direction | ||
| }: HeaderRowProps<R, SR, K>) { | ||
| const dragDropKey = useId(); | ||
| const [draggedColumnKey, setDraggedColumnKey] = useState<string>(); |
Collaborator
Author
There was a problem hiding this comment.
We can move this to the parent component and reorder columns internally as user is dragging. I will check
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| if (document.startViewTransition) { |
Collaborator
Author
There was a problem hiding this comment.
FF does not support this
amanmahajan7
marked this pull request as ready for review
May 15, 2025 19:38
nstepien
reviewed
May 16, 2025
| /> | ||
| ); | ||
| } | ||
|
|
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
nstepien
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.