Replace use of i for column index which is no longer passed in - #1344
Merged
Merged
Conversation
This was part of the cause of Comcast#1343
malonecj
approved these changes
Nov 13, 2018
rossjp
pushed a commit
to rossjp/react-data-grid
that referenced
this pull request
Dec 14, 2018
…st#1344) This was part of the cause of Comcast#1343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a previous PR, the column index
ihad been partly replaced. However, it wasn't fully rolled out, so the fallback to using the column index as the key is no longer working. This was part of the cause of #1343This PR fully implements the replacement of
iwithcolumn.idx.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Nested arrays cannot be displayed correctly in a Grid since v5
What is the new behavior?
Nested arrays can now be displayed
Does this PR introduce a breaking change? (check one with "x")