London | 26-ITP-MAY | Chinwe Chukwuma | Sprint 1 | Form Controls#1392
Open
ChinweP wants to merge 17 commits into
Open
London | 26-ITP-MAY | Chinwe Chukwuma | Sprint 1 | Form Controls#1392ChinweP wants to merge 17 commits into
ChinweP wants to merge 17 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
ChinweP
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ChinweP
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ChinweP
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ChinweP
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Jun 3, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done. The functionality is correct. I have a minor comment about separating the styles
| <meta name="description" content="Form for ordering T-Shirts" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
|
|
||
| <style> |
There was a problem hiding this comment.
How could you separate the code for the styling from the HTML to make it easier to review (because of smaller files with separate responsibilities)
| name="name" | ||
| type="text" | ||
| required | ||
| pattern=".*\S.*\S.*" |
Comment on lines
+70
to
+75
| <select id="colour" name="colour" required> | ||
| <option value="">Select Your Colour</option> | ||
| <option value="Burgundy">Burgundy</option> | ||
| <option value="Purple">Purple</option> | ||
| <option value="Yellow">Yellow</option> | ||
| </select> |
There was a problem hiding this comment.
FYI: I would switch around the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options a dropdown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I created a branch for this project called (features/form-controls). I built an HTML form for ordering T‑shirts that collects the customer’s full name, email address, colour choice, and size. I ensured the form meets the assignment requirements for form controls and validation by adding labels to all inputs to improve accessibility and using semantic structure such as fieldset and legend for grouped inputs. I styled the form and moved the style block into the head to pass W3C validation and Lighthouse accessibility checks. I also made several adjustments to the name and email labels to ensure the form's Lighthouse accessibility check is a 100.