Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Form Controls#1390
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Form Controls#1390lintsang wants to merge 11 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lintsang
added
the
Needs Review
akeren
added
Review in progress
| h1{ | ||
| font-family: 'Times New Roman', Times, serif; | ||
| font-size: 1.5rem; | ||
| } |
There was a problem hiding this comment.
@lintsang, please provide a breathing line after each element as you've done for the others like fieldset and legend.
|
|
||
|
|
There was a problem hiding this comment.
@lintsang, these empty lines of code can be removed; hence, it does not add value to your implementation. This rather consumes memory unnecessarily.
| border-radius: 0.3em; | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
@lintsang, the same breathing space should apply to closing the legend element before starting the next target element.
| padding: 0.5em 3em; | ||
| display: grid; | ||
| grid-template-columns: 2fr 4fr; | ||
| } |
There was a problem hiding this comment.
@lintsang the breathing space after the closing of the element before starting input.
There was a problem hiding this comment.
I have learnt about the importance of cleanliness and tidiness of css coding. Many thanks!
| <title>My Sprint 1 form controls exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="css/style.css"> |
There was a problem hiding this comment.
Learning note: This stylesheet link is valid in modern HTML5 without type="text/css" because browsers infer the file type from rel="stylesheet". However, you may also see the fuller version:
<link rel="stylesheet" type="text/css" href="css/style.css">The type="text/css" part explicitly says the linked file is CSS. It is not required in modern HTML, but it is useful to understand what it means.
| <legend> | ||
| Person name and email</legend> |
There was a problem hiding this comment.
@lintsang, could you consider formatting this to one line to enable it to follow the same coding style as you've done for the rest of the HTML tags?
There was a problem hiding this comment.
I have also updated this line. Thanks!
akeren
added
Complete
lintsang
added
the
Needs Review
akeren
added
Review in progress
akeren
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
I made sure the corresponding sprint exercise was submitted to this PR.