-
-
Notifications
You must be signed in to change notification settings - Fork 500
London | 26-ITP-May | Gideon Defar | Sprint 1 | Form Control #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gideondefar
wants to merge
16
commits into
CodeYourFuture:main
Choose a base branch
from
gideondefar:feature/form-control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+218
−25
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d845fd4
create form
gideondefar b9cc5f9
a strict validation rule
gideondefar 6b3b802
lighthouse
gideondefar 956c48d
pattern
gideondefar dbce8f7
footer text align to center
gideondefar a511293
rebase
gideondefar 9057623
Fix missing newline at end of index.html
gideondefar fd5f1a4
Remove unnecessary empty line in style.css
gideondefar 9388fc6
Fix CSS formatting by removing unnecessary closing brace
gideondefar a33f433
Fix CSS syntax for image grid column span
gideondefar 163d801
Update form inputs and labels for customer details
gideondefar 4db1db6
Resolve merge conflict in Form-Controls index.html
gideondefar 4986b40
Text input for name, and email input for email with proper validation
gideondefar 0a8d6bf
fix the min length of the customer name
gideondefar c06be2b
link CSS with semantic HTM and alter few edge cases of the email pattern
gideondefar 60c2d63
restore Wireframe/index.html to main version
gideondefar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,81 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
|
|
||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="T-Shirt Order Form" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- Customer Name Input --> | ||
| <p> | ||
| <label for="customerName">Name:</label> | ||
| <input type="text" id="customerName" name="customerName" required minlength="3" | ||
| pattern=".*\S.*\S.*" placeholder="Enter your full name"> | ||
| </p> | ||
|
|
||
| <!-- Customer Email Input --> | ||
| <p> | ||
| <label for="emailAddress">Email:</label> | ||
| <input type="email" id="emailAddress" name="emailAddress" required placeholder="you@gmail.com" | ||
| pattern="^[^@\s]+@[^@\s]+\.[^@\s]+$" | ||
|
gideondefar marked this conversation as resolved.
Outdated
|
||
| title="Please enter a valid email address (e.g., user@gmail.com). Domain parts (like 'gmail') must start and end with a letter or number, can contain hyphens, and must be separated by dots. Ends with a top-level domain (e.g., .com)."> | ||
| </p> | ||
|
|
||
| <!-- T-Shirt Colour Selection --> | ||
| <fieldset> | ||
| <legend>Choose T-Shirt Colour:</legend> | ||
| <p> | ||
| <label> | ||
| <input type="radio" name="shirt-colour" value="red" required> | ||
| Red | ||
| </label> | ||
| </p> | ||
| <p> | ||
| <label> | ||
| <input type="radio" name="shirt-colour" value="blue" required> | ||
| Blue | ||
| </label> | ||
| </p> | ||
| <p> | ||
| <label> | ||
| <input type="radio" name="shirt-colour" value="green" required> | ||
| Green | ||
| </label> | ||
| </p> | ||
| </fieldset> | ||
|
|
||
| <!-- T-Shirt Size Selection --> | ||
| <p> | ||
| <label for="shirtSize">Choose Size:</label> | ||
| <select id="shirtSize" name="shirtSize" required> | ||
| <option value="">-- Please choose a size --</option> | ||
| <option value="xs">XS</option> | ||
| <option value="s">S</option> | ||
| <option value="m">M</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XXL</option> | ||
| </select> | ||
| </p> | ||
|
|
||
| <!-- Submit Section Button --> | ||
| <p> | ||
| <button type="submit">Place Order</button> | ||
| </p> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <h2>By Gideon Defar</h2> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.