Skip to content

Manchester | ITP-May-2026 | Szidonia Bodo | Sprint 2 | Wireframe#1381

Closed
bodoszidi wants to merge 16 commits into
CodeYourFuture:mainfrom
bodoszidi:wireframe
Closed

Manchester | ITP-May-2026 | Szidonia Bodo | Sprint 2 | Wireframe#1381
bodoszidi wants to merge 16 commits into
CodeYourFuture:mainfrom
bodoszidi:wireframe

Conversation

@bodoszidi
Copy link
Copy Markdown

@bodoszidi bodoszidi commented May 31, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Updated HTML with context and CSS styling

Questions

bodoszidi added 16 commits May 12, 2026 21:49
@bodoszidi
Update index.html
32ee3d6 
-removed text from the form section
-updated footer with my name
@bodoszidi
Update index.html
4b959c7 
added name and email with validation
@bodoszidi
Update index.html
554671e 
added T-shirt colour and size to the form with validation
@bodoszidi
Update index.html
17b98d8 
added css style to the content
@bodoszidi
Update index.html
fb1e777 
closed the select tag and added 2 buttons to the form
@bodoszidi
Update index.html
b54317a 
-updated form field and add required attributes
-fixed styling by adding flex and updating width on CSS
@bodoszidi
Update index.html
7cf1c6d 
updated the button css style
fixed the colour selector css
@bodoszidi
Update index.html
dbfaed7 
added required field to the size selector
@bodoszidi
added title and description
744e09d
@bodoszidi
added new images
c419d6c
@bodoszidi
updated content to HTML page
ad8d59f 
-added README file short description and picture
-added Wireframe short description and picture
-added Git Branching short description and picture
-updated footer
@bodoszidi
CSS chages
7a88528 
-removed the instruction
-updated a styling the border colour
-added h1, h2 and p style
-removed fixed position of the footer
@bodoszidi
updated css using classes using grid
f77c492
@bodoszidi
updated css with grid
cb3e300
@bodoszidi
updated the css color and sizing
4117384
@bodoszidi
css final update
ba3f146
@netlify
Copy link
Copy Markdown

netlify Bot commented May 31, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit ba3f146
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1c887bde44380008f4d5ad
😎 Deploy Preview https://deploy-preview-1381--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 89 (🔴 down 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@bodoszidi bodoszidi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 31, 2026

There is a modified file in the "Form-Controls" folder. Because the file is not related to this exercise, the Validation bot rejected this PR.

To fix the issue, you need to revert the changes made in the "Form-Controls" folder.
If you do not know how to revert the changes, you can just create a new branch, submit a new PR, and then close this PR.

Please note that when you are creating a new branch, you should ensure you are creating it from main.

@Liam310 Liam310 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@bodoszidi bodoszidi closed this Jun 1, 2026
@bodoszidi bodoszidi deleted the wireframe branch June 1, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bodoszidi @cjyuan @Liam310