Skip to content

Cape Town | 26-ITP-MAY | LIYEMA MFENGWANA | Sprint 2 | WIREFRAME#1370

Open
LiyemaMfengwana wants to merge 5 commits into
CodeYourFuture:mainfrom
LiyemaMfengwana:wireframe-sprint2
Open

Cape Town | 26-ITP-MAY | LIYEMA MFENGWANA | Sprint 2 | WIREFRAME#1370
LiyemaMfengwana wants to merge 5 commits into
CodeYourFuture:mainfrom
LiyemaMfengwana:wireframe-sprint2

Conversation

@LiyemaMfengwana
Copy link
Copy Markdown

@LiyemaMfengwana LiyemaMfengwana commented May 30, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added a new webpage explaining README files
  • Added information about wireframes
  • Added information about Git branches
  • Styled the page to match the provided wireframe
  • Updated HTML and CSS files

@netlify
Copy link
Copy Markdown

netlify Bot commented May 30, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 74f644d
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1e9b527be117000813d5df
😎 Deploy Preview https://deploy-preview-1370--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 94 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@LiyemaMfengwana LiyemaMfengwana added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@LiyemaMfengwana
Copy link
Copy Markdown
Author

LiyemaMfengwana commented May 30, 2026

all my previous commits are gone cause i had fix a pull request issue

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 30, 2026

You don't have to include in the PR description the "answers" to the questions in the README file.
image

However, your PR description is missing a "Changelist" section.
Please refer to this guide to see how to prepare the "Changelist" section.

cjyuan
cjyuan reviewed May 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of error. Page layout looks good.

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  • To better match the wireframe, can you make the "Read More" link fully aligned horizontally?

Image

Comment thread Wireframe/style.css
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It appears that some CSS selectors in this file do not match any elements in the HTML. As a best practice, unused code should be removed to keep the codebase clean and maintainable.

  2. Some of the code is not consistent formatted.

    As a best practice, consider following this guide to enable VS Code's
    "Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

Copy link
Copy Markdown
Author

@LiyemaMfengwana LiyemaMfengwana Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes have been made

Comment thread Wireframe/index.html
Comment on lines +62 to +69
<article class="card">
<div class="card__media">
<img src="https://images.unsplash.com/photo-1555949963-aa79dcee981c"
alt="Developer working with Git and code">
</div>
<div class="card__body">
<h2 class="card__title">What is a branch in Git?</h2>
<p class="card__summary">
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that in practice adding elements that are not included in the wireframe may not be advisable, as it can lead to deviations from the intended design.

No change needed.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
@LiyemaMfengwana LiyemaMfengwana added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
cjyuan
cjyuan reviewed Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Well done.

Comment thread Wireframe/style.css
Comment on lines +37 to +44
font-family:
"Inter",
system-ui,
-apple-system,
Segoe UI,
Roboto,
Arial,
sans-serif;
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why specify so many backup fonts? Segoe UI should be enclosed by quotes.

Copy link
Copy Markdown
Author

@LiyemaMfengwana LiyemaMfengwana Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback . I added the quotes around "Segoe UI". I used the longer fallback stack to provide font alternatives across different operating systems.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LiyemaMfengwana @cjyuan