Skip to content

London | ITP May-2026 | Dipa Sarker | Sprint 2 | wireframe-final#1328

Open
Dipa-Sarker wants to merge 4 commits into
CodeYourFuture:mainfrom
Dipa-Sarker:wireframe-final
Open

London | ITP May-2026 | Dipa Sarker | Sprint 2 | wireframe-final#1328
Dipa-Sarker wants to merge 4 commits into
CodeYourFuture:mainfrom
Dipa-Sarker:wireframe-final

Conversation

@Dipa-Sarker
Copy link
Copy Markdown

@Dipa-Sarker Dipa-Sarker commented May 21, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Created a webpage using HTML and CSS based on the wireframe. The page explains README files, wireframes, and Git branches.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 21, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2b159f1
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1d60c72a4e7c00080f1758
😎 Deploy Preview https://deploy-preview-1328--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Dipa-Sarker
Copy link
Copy Markdown
Author

Dipa-Sarker commented May 21, 2026

I encountered some issues with the PR. In the Module-Onboarding repository, both the Form Controls and Wireframe folders exist, which caused confusion and made it difficult to identify the correct assignment folder. To resolve this, I created a new branch named "wireframe-final" to ensure the submission only includes the Wireframe task.

@Dipa-Sarker Dipa-Sarker added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 21, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 27, 2026
LonMcGregor
LonMcGregor reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this task, could you check the criteria again and see my comment about the footer?

Comment thread Wireframe/index.html
<p>
This is the default, provided code and no changes have been made yet.
</p>
<p>Web Development Basics | README, Wireframe & Git Branches</p>
Copy link
Copy Markdown

@LonMcGregor LonMcGregor May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see the criteria about what the footer should do? Check the readme

Copy link
Copy Markdown
Author

@Dipa-Sarker Dipa-Sarker May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "Footers Usually Contain Contact Links and Other Information about the site Overall"?
Is this the criteria?

Copy link
Copy Markdown

@LonMcGregor LonMcGregor May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The footer is meant to be fixed to the bottom of the viewport - Can you try to implement that?

Copy link
Copy Markdown
Author

@Dipa-Sarker Dipa-Sarker May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I have updated the footer based on the feedback. Can you please review again and give me the feedback? Thank you!

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026
@Dipa-Sarker Dipa-Sarker added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 31, 2026
LonMcGregor
LonMcGregor reviewed Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! The footer is now fixed to the bottom of the viewport.

However as you scroll, you can sometimes see the page text and the footer text overlapping. Can you make a change to the style so that the footer remains readable as you scroll?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 1, 2026
@Dipa-Sarker
Copy link
Copy Markdown
Author

Dipa-Sarker commented Jun 1, 2026

Thank you for your review. I have updated the footer according to your feedback. Can you please check again and give me feedback if needed? Thank you!

@LonMcGregor
Copy link
Copy Markdown

LonMcGregor commented Jun 1, 2026

Perfect! This task is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 1, 2026
@Dipa-Sarker
Copy link
Copy Markdown
Author

Dipa-Sarker commented Jun 1, 2026

Thank you so much!

@Dipa-Sarker Dipa-Sarker mentioned this pull request Jun 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dipa-Sarker @LonMcGregor