Cape Town | May-ITP-2026 | Enice Mutanda | Sprint 1 | FormControls#1291
Open
Enice-Codes wants to merge 3 commits into
Open
Cape Town | May-ITP-2026 | Enice Mutanda | Sprint 1 | FormControls#1291Enice-Codes wants to merge 3 commits into
Enice-Codes wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Enice-Codes
changed the title
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
the
Needs Review
github-actions
Bot
removed
the
Needs Review
Enice-Codes
changed the title
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 20, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
I see a lot of errors when I paste the html in the w3 validator: https://validator.w3.org/nu/#textarea. How can you fix them?
How can you ensure a lighthouse score of 100?
| this will also help you fill in your PR message later--> | ||
| <form action="results.html" method="GET"> | ||
| <div> | ||
| <label for="name">Customer Name:</label> |
There was a problem hiding this comment.
The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?
Author
There was a problem hiding this comment.
I can use a code formatter such as Prettier. It automatically indents child elements and keeps the HTML structure neat and easy to read whenever I save my file.
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="style.css" > |
Author
There was a problem hiding this comment.
This file is linked to the css file.
| <form action="results.html" method="GET"> | ||
| <div> | ||
| <label for="name">Customer Name:</label> | ||
| <input type="text" id="name" name="name" required placeholder="two non-space characters."/> |
There was a problem hiding this comment.
How can you ensure that the user needs to input 2 non space characters?
Author
There was a problem hiding this comment.
I can use the pattern attribute in side the element to tell the browser what format the user's input must follow. than next to the pattern attribute , i can than use the Title attribute to show a helpful message to tell users what is expect of them
There was a problem hiding this comment.
The placeholder is nice information for the user. Please also enforce the rules programatically
Luro91
added
Reviewed
Enice-Codes
added
the
Needs Review
Luro91
reviewed
Jun 1, 2026
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="style.css" > |
| this will also help you fill in your PR message later--> | ||
| <form action="results.html" method="GET"> | ||
| <div> | ||
| <label for="name">Customer Name:</label> |
There was a problem hiding this comment.
Please also fix my comments from the review text itself: #1291 (review)
| <form action="results.html" method="GET"> | ||
| <div> | ||
| <label for="name">Customer Name:</label> | ||
| <input type="text" id="name" name="name" required placeholder="two non-space characters."/> |
There was a problem hiding this comment.
The placeholder is nice information for the user. Please also enforce the rules programatically
Luro91
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I used Html to create a form using provided information. I added other details such as phone number and reset button to make the form look professional. I used CSS to style the form to make it attractive and simple . tested the changes and was satisfied with the results.