bug: `Model::find()` returns incorrect type

[kenjis]

PHP Version

8.2

PHPStan CodeIgniter Version

v1.4.3.70400

PHPStan Version

1.10.58

What happened?

Model::find() returns incorrect type.
See codeigniter4projects/playground#218 (comment)

Minimum Reproduction Script

    public function testMakesMonsterWithDungeon()
    {
        $monster = $this->fabricator->make();
        $dungeon = model(DungeonModel::class)->find($monster->dungeon_id);

        $this->assertInstanceOf(Dungeon::class, $dungeon); // Line 49
    }

 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   tests/database/FakerTest.php                                                                              
 ------ ---------------------------------------------------------------------------------------------------------- 
  49     Call to method PHPUnit\Framework\Assert::assertInstanceOf() with 'App\\Entities\\Dungeon' and array<int,  
         App\Entities\Dungeon> will always evaluate to false.                                                      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting                       
            treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                            
 ------ ---------------------------------------------------------------------------------------------------------- 

Expected Output

The $dungeon type is App\\Entities\\Dungeon.

[paulbalandan]

What is the dumped value of \PHPStan\dumpType($monster->dungeon_id);

[kenjis]

 ------ ------------------------------ 
  Line   tests/database/FakerTest.php  
 ------ ------------------------------ 
  47     Dumped type: *ERROR*          
 ------ ------------------------------ 

This is an issue on Fabricator::make(). It returns array|object.

$monster = $this->fabricator->make();

[paulbalandan]

Yes, because PHPStan does not know what really $monster is, the fetch of ->dungeon_id results in error.

A workaround is to add exhaustive tests.

    public function testMakesMonsterWithDungeon()
    {
        $monster = $this->fabricator->make();
        $this->assertIsObject($monster);
        $this->assertTrue(property_exists('dungeon_id', $monster));
        $this->assertIsInt($monster->dungeon_id); // or assertIsString, whatever the case for this

        $dungeon = model(DungeonModel::class)->find($monster->dungeon_id);
        $this->assertInstanceOf(Dungeon::class, $dungeon); // this should be fine, but if using strict-rules might still error
    }

[paulbalandan]

Fixed in Fixed in https://github.com/CodeIgniter/phpstan-codeigniter/tree/v2.0.0