chore: add update notification to both binaries#1252
Closed
mathiasbynens wants to merge 1 commit intomainfrom
Closed
chore: add update notification to both binaries#1252mathiasbynens wants to merge 1 commit intomainfrom
mathiasbynens wants to merge 1 commit intomainfrom
Conversation
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
Two things:
- Should we wrap it in a helper to reuse same code?
- Should we use
shouldNotifyInNpmScriptas we usenpx?
mathiasbynens
force-pushed
the
add-update-notification
branch
from
424e86b to
e0f9d04
Compare
Member
Author
OrKoN
reviewed
Mar 30, 2026
Both `chrome-devtools` and `chrome-devtools-mcp` now log a notification when a newer version is detected to be available.
mathiasbynens
force-pushed
the
add-update-notification
branch
from
e0f9d04 to
4d4a257
Compare
OrKoN
reviewed
Mar 30, 2026
| "node": "^20.19.0 || ^22.12.0 || >=23" | ||
| }, | ||
| "dependencies": { | ||
| "update-notifier": "^7.3.1" |
Collaborator
There was a problem hiding this comment.
this needs to be a dev-dependency, re-exported in src/third_party/index.ts so that it is bundled
Member
Author
There was a problem hiding this comment.
Capturing offline discussion: alternatively, we can just request https://registry.npmjs.org/chrome-devtools-mcp/latest (failing silently in case of any errors) and compare the version number. If the request succeeds and the version number is different, we log the message. I vastly prefer this approach as it avoids transitive dependencies and complications.
Member
Author
There was a problem hiding this comment.
Member
Author
|
Closing in favor of #1783. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
chrome-devtoolsandchrome-devtools-mcpnow log a notification when a newer version is detected to be available.Issue: https://crbug.com/496757598