Skip to content

fix(js): roll back module lifecycle initialization #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GrapeBaBa wants to merge 6 commits into from
Closed

fix(js): roll back module lifecycle initialization #52

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00741c5
fix(js): roll back module lifecycle initialization
GrapeBaBa Jul 14, 2026
d6bc9cf
refactor(js): make lifecycle rollback ownership explicit
GrapeBaBa Jul 14, 2026
8cbef43
refactor(js): model module attach lifecycle explicitly
GrapeBaBa Jul 14, 2026
20c5d30
refactor(js): simplify module init rollback
GrapeBaBa Jul 14, 2026
7f6563a
refactor(js): minimize lifecycle rollback
GrapeBaBa Jul 14, 2026
1835f96
docs: document module lifecycle rollback
GrapeBaBa Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/js/export_module.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,27 @@ pub fn exportModule(comptime Module: type, comptime options: anytype) void {
};

var prev_refcount: u32 = 0;
var init_succeeded = false;
if (has_lifecycle) {
prev_refcount = State.env_refcount.fetchAdd(1, .monotonic);
errdefer if (!cleanup_hook_registered) {
_ = State.env_refcount.fetchSub(1, .acq_rel);
};

if (has_init) {
try options.init(prev_refcount);
}
errdefer if (!cleanup_hook_registered) {
if (has_lifecycle) {
const prev_refcount_rollback = State.env_refcount.fetchSub(1, .acq_rel);
std.debug.assert(prev_refcount_rollback > 0);
const new_refcount = prev_refcount_rollback - 1;

if (has_cleanup) {
if (init_succeeded) {
options.cleanup(new_refcount);
}
}
}
};

if (has_init) {
try options.init(prev_refcount);
init_succeeded = true;
}

_ = try registerDecls(Module, env, module, 0);
Expand Down
Loading