feat: partial validator monitor - #475
Open
spiral-ladder wants to merge 2 commits into
Open
Conversation
Implements the missing validator monitor metrics from lodestar-ts. Note that there are some metrics intentionally omitted because they probably require even bigger changes on the zig side, this is just the minimal change required to track validator perf. The following metrics are excluded: - `validator_monitor_prev_epoch_on_chain_attester_hit_total` - `validator_monitor_prev_epoch_on_chain_attester_miss_total` - `validator_monitor_prev_epoch_on_chain_attester_correct_head_total` - `validator_monitor_prev_epoch_on_chain_attester_incorrect_head_total` - `validator_monitor_prev_epoch_on_chain_inclusion_distance` These will be updated on the TS side to run on `onceEveryEndOfEpoch` rather than inside `registerValidatorStatuses`, which is now zig native
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the missing validator monitor metrics from lodestar-ts.
Note that there are some metrics intentionally omitted because they probably require even bigger changes on the zig side, this is just the minimal change required to track validator perf.
The following metrics are excluded:
validator_monitor_prev_epoch_on_chain_attester_hit_totalvalidator_monitor_prev_epoch_on_chain_attester_miss_totalvalidator_monitor_prev_epoch_on_chain_attester_correct_head_totalvalidator_monitor_prev_epoch_on_chain_attester_incorrect_head_totalvalidator_monitor_prev_epoch_on_chain_inclusion_distanceThese will be updated on the TS side to run on
onceEveryEndOfEpochrather than insideregisterValidatorStatuses, which is now zig native