feat(STF): implement Gloas Fork - #462
Conversation
spiral-ladder
left a comment
spiral-ladder
left a comment
There was a problem hiding this comment.
first pass, mostly on utils/gloas.zig
| } | ||
|
|
||
| pub fn canBuilderCoverBid(allocator: Allocator, state: *BeaconState(.gloas), builder_index: u64, bid_amount: u64) !bool { | ||
| var builders = try state.inner.get("builders"); |
There was a problem hiding this comment.
| var builders = try state.inner.get("builders"); | |
| var builders = try state.inner.getReadonly("builders"); |
| var data: PtcWindowEpochCacheData = undefined; | ||
|
|
||
| for (0..preset.SLOTS_PER_EPOCH) |i| { | ||
| try ptc_window.getValue(undefined, i, &data.previous[i]); |
There was a problem hiding this comment.
out of scope of this PR, but would be nice if we had getReadonlyByRange for this usecase
|
One overarching thought that is out of scope of this PR is that I still kinda dislike the whole dumping of everything into |
|
#464 might've broken |
|
I suggest to add some OOM/Double free fault injection test using the |
I did the benchmarking and found near to no regresssions. |
5 participants
This pr implements
v1.7.0-alpha.11supersedes feat(STF): implement Gloas Fork #303