[draft][ENG-12182] fix: more consistent naming of celery tasks - #11916
Draft
aaxelb wants to merge 1 commit into
Draft
[draft][ENG-12182] fix: more consistent naming of celery tasks#11916aaxelb wants to merge 1 commit into
aaxelb wants to merge 1 commit into
Conversation
for celery tasks defined under `osf/management/commands/`, use task names that begin with the full python module path (use celery's default task name in most cases) specifically, this fixes a problem where tasks were expected to be "low priority" based on matching `CeleryConfig.low_pri_modules`, but would instead go in the default queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
for celery tasks defined under
osf/management/commands/, use task names that begin with the full python module path (use celery's default task name in most cases)specifically, this fixes a problem where tasks were expected to be "low priority" based on matching
CeleryConfig.low_pri_modules, but would instead go in the default queueChanges
low_pri_modulesentries with mismatched task names that went to the default queue instead:Side Effects
QE Notes
CE Notes
Documentation