Optimize response negotiator selection performance#385
Merged
jchannon merged 1 commit intoJul 4, 2026
Conversation
jchannon
approved these changes
Jul 4, 2026
Member
|
Thanks. Great work 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
While looking through the response negotiation path, I noticed a few unnecessary allocations and LINQ operations in code that runs on every negotiated response.
This PR improves it by:
List<IResponseNegotiator>with an array snapshotOrderByDescending,First,FirstOrDefault)Acceptheader quality orderingNo behavior changes are intended.
Why
The negotiation path runs on every negotiated response, so even small allocations and LINQ overhead add up.
This keeps the existing behavior while reducing allocations and lowering the cost of the hot path.
The insertion sort is intentional here since
Acceptheaders are typically very small, making it a simple, allocation-free choice while preserving the ordering of equal quality values.Benchmark
I benchmarked the original implementation against this version using BenchmarkDotNet.
Memory allocations were also reduced significantly:
Benchmark output
The benchmark covers a few representative scenarios:
Notes