feat: new SINCLAIR functions - #7
Conversation
kelly-sovacool
left a comment
There was a problem hiding this comment.
There are remnants from unsolved merge conflicts in a few files, please remove them
They look like this:
<<<<<<< HEAD
=======
>>>>>>> COMMIT_HASH
This comment was marked as outdated.
This comment was marked as outdated.
|
Now would be a great time to create or borrow a very small test dataset and create unit tests -- see https://usethis.r-lib.org/reference/use_r.html |
There was a problem hiding this comment.
All of the comments I left previously haven't been addressed. Please either commit the suggestion, push a commit that addresses the comment, or respond to the comment to start a discussion about the merits of the suggestion. Only mark the conversation as resolved once it has either been addressed or we've discussed that it doesn't need to be addressed.
|
Also, please run |
Merge conflict correction and BioConductor dependencies Co-authored-by: Kelly Sovacool, PhD <kelly-sovacool@users.noreply.github.com>
Done |
|
R CMD check failed -- I'll work on fixing the problems and push to this branch directly. Later we can have a debrief about it so you can pre-empt these problems as you write code. |
|
notes from |
|
Down to 2 remaining R CMD check notes:
|
Changes
Primary upload to include SINCLAIR functions:
Includes ad hoc functions which will also be updated as needed for formatting:
Issues
Resolves #6 by migrating the substance of https://github.com/CCBR/SINCLAIR/blob/main/bin/scRNA_functions.R into an R package.
PR Checklist
(
Strikethroughany points that are not applicable.)[ ] UpdateNEWS.mdwith a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.htmldevtools::check()locally and fix all notes, warnings, and errors.