feat(sdk-coin-eth): add zama token withdrawal support#8919
Draft
MohammedRyaan786 wants to merge 1 commit into
Draft
feat(sdk-coin-eth): add zama token withdrawal support#8919MohammedRyaan786 wants to merge 1 commit into
MohammedRyaan786 wants to merge 1 commit into
Conversation
TICKET: CHALO-529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: CHALO-529
This pull request adds support for confidential ERC-7984 token transfers to the Ethereum SDK. The main changes introduce a new
TransferBuilderERC7984class, extend transaction building and verification logic to handle the new confidential transfer type, and provide decoding utilities for confidential transfer calldata. Unit tests are also updated to cover the new functionality.ERC-7984 Confidential Transfer Support:
TransferBuilderERC7984inabstract-eth, enabling construction and serialization of confidential ERC-7984 token transfers, with validation for required fields likeencryptedHandleandinputProof.TransferBuilderERC7984from transfer builder index files for bothabstract-ethandsdk-coin-ethmodules. (F010bc2dR1, modules/sdk-coin-eth/src/lib/transferBuilders/index.tsL1-R8)Transaction Builder and Type Handling:
TransactionBuilderclasses in bothabstract-ethandsdk-coin-ethto support the newSendERC7984transaction type, including type checks, instantiation, and handling in relevant methods. [1] [2] [3] [4] [5] [6] [7] [8] [9]Confidential Transfer Decoding and Classification:
decodeConfidentialTransferDatautility to parse confidential transfer calldata from raw transaction data, extracting recipient, contract, handle, proof, and signature.SendERC7984by inspecting inner calldata.walletUtil.Verification Logic:
verifyConfidentialTransfermethod toErc7984Token, verifying contract address, recipient, and presence of confidential fields in decoded calldata, and integrated this check into the main transaction verification flow. [1] [2]Testing:
These changes collectively enable secure construction, parsing, and verification of confidential ERC-7984 token transfers within the SDK.