fix(abstract-eth): decode ERC20 calldata in consolidation base address#8797
Open
HimanshuS2212 wants to merge 1 commit into
Open
fix(abstract-eth): decode ERC20 calldata in consolidation base address#8797HimanshuS2212 wants to merge 1 commit into
HimanshuS2212 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: COINS-208
The consolidationToBaseAddress check compared txJson.to against the wallet base address. For ERC20 token consolidations on v6 TSS wallets, txJson.to is the token contract address, not the actual recipient. The real recipient is encoded in the transfer(address,uint256) calldata. This caused a TxIntentMismatchRecipientError for all ERC20 token consolidations on v6 TSS wallets, blocking users from consolidating. The fix decodes the 0xa9059cbb calldata to extract the actual transfer recipient before comparing against the base address, using the same pattern already present in the non-consolidation transfer verification block.