Re-enable GUI Near Menu test on D3D11 (idx 177)#1698
Open
bkaradzic-microsoft wants to merge 1 commit into
Open
Re-enable GUI Near Menu test on D3D11 (idx 177)#1698bkaradzic-microsoft wants to merge 1 commit into
bkaradzic-microsoft wants to merge 1 commit into
Conversation
Original exclusion reason ('Test crashes on Win32 V8 D3D11 / hangs on
OpenGL') no longer reproduces on Chakra D3D11 post BabylonJS#1695:
* Win32 D3D11 (Chakra Release x64): 783 px diff, validated.
* Windows ANGLE / Linux OpenGL: still crashes, but now as a clean BGFX
FATAL shader-compile error (`'=' : cannot convert from 'highp float'
to 'bool'`) rather than a silent hang -- same class as the
PrePassRenderer `mediump float`/`int` issue. Excluded via
`excludedGraphicsApis: [\"OpenGL\"]` until the GLSL emit path is fixed.
V8-specific regression is no longer part of the active V8 cascade
(other `ACCESS_VIOLATION` cascade victims in config.json are still
guarded by their own reasons).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables
validation_native.jstest idx 177GUI Near Menu(#2YZFA0#302) on D3D11 and adds an OpenGL-only exclusion for the residual fragment-shader-compile crash.What changed
The original exclusion reason was:
Both halves of that statement are now stale:
Win32 D3D11 (Chakra Release x64): the test now runs to completion with 783 px diff (well under the 2.5%
errorRatiothreshold) and validates. The originalWin32 V8 D3D11ACCESS_VIOLATIONwas specific to the V8 cascade and is no longer reproducible on Chakra. Other V8-cascade victims inconfig.jsonkeep their own exclusion reasons.OpenGL (Windows ANGLE + Linux native OpenGL): the test no longer "hangs". With the console hook landed in Improve Playground debuggability. #1688 and the bgfx FATAL routed through
BgfxCallback, the previous silent hang is now a clean shader-compile failure:This is the same family of GLSL implicit-precision-conversion bug already affecting idx 293/296/299 (
mediump float->intin the PrePassRenderer fragment shader); here the conversion ishighp float->boolin a GUI fragment shader. Tracked separately for the OpenGL backend; for now the test is gated withexcludedGraphicsApis: ["OpenGL"].Verification
Notes
Apps/Playground/Scripts/config.json); the binary build is unaffected.excludedGraphicsApismechanism added in Bump SPIRV-Cross to 866e5edcc3407997a3ed62f3edf492f91bcb2629 (Expose more functions #10) #1695 is reused here to keep the test running on every backend where it works while gating it on backends where it doesn't.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com